[PATCH] Use cached XKB keymap when rules haven't changed

Peter Hutterer peter.hutterer at who-t.net
Sun Nov 23 21:21:15 PST 2008


On Sun, Nov 23, 2008 at 06:06:54PM -0800, Dan Nicholson wrote:
> Rather than compiling a new keymap every time XkbInitKeyboardDeviceStruct
> is called, cache the previous keymap and reuse it if the rules have not been
> changed. When XkbSetRulesDflts is called, the cached map is invalidated if
> it differs from the previous default rules.
> 
> The map is also invalidated if named components are supplied. This could be
> fixed by caching Ktcsg from the previous run and comparing.

looks good, but - it doesn't work. Caching and re-using seems to work but it
breaks different keymaps for different devices.

Just configure one keyboard to have a different layout in your fdi file (e.g.
de) and start a plain server and xterm. In current master, the keyboard has
the specified layout, with your patch it has the default layout (us).
Can you please test and fix this? Thanks.

Cheers,
  Peter



More information about the xorg mailing list