Ansification of X.Org code & other cleanup work

[Peter Breitenlohner]

On Mon, 20 Oct 2008, Alan Coopersmith wrote:

Hi Alan,

in your mail starting this thread

> If someone wanted to organize a "janitorial squad" to tackle these and help
> new people work through them to get to the point where they were ready for
> commit access, we'd love you forever (or at least until you turn us down
> when we then volunteer you to be the next release manager).

> [3] 122 open bugs, though many patches aren't keyworded:
> http://bugs.freedesktop.org/buglist.cgi?keywords=patch&product=Xorg&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED

you suggested to have a look at these bugs and patches. In the meantime I
have done just that.  There are quite a few easy ones (apply cleanly to
current git and are obvious changes such as strict ANSI C function
definitions, fixing some small bugs, and similar).

Here my recommendations:

====================

app/viewres
 	bugid=18479 patchid=20208	apply

app/xf86dga
 	bugid=15084 patchid=15215	apply

app/xfd
 	bugid=18479 patchid=20209	apply

app/xfontsel
 	bugid=15083 patchid=15214	apply

app/xgc
 	bugid=18479 patchid=20210	apply

app/xkbprint
 	bugid=12790 patchid=12008	apply, maybe without commented old code
 	bugid=15078 patchid=15207	apply with --whitespace=fix

app/xkbutils
 	bugid=15077 patchid=15206	apply

app/xload
 	bugid=15075 patchid=15205	apply

app/xlsfonts
 	bugid=15073 patchid=15203	apply

app/xmessage
 	bugid=15072 patchid=15202	apply

app/xmh
 	bugid=15071 patchid=15201	apply
 	bugid=18479 patchid=20211	apply

app/xprop
 	bugid=16154 patchid=16813	apply

app/xsm
 	bugid=15066 patchid=15196	apply
 	bugid=18479 patchid=20212	apply

====================

where bugid=nnnn refers to
 	http://bugs.freedesktop.org/show_bug.cgi?id=nnnnn
and patchid=nnnnn to
 	http://bugs.freedesktop.org/attachment.cgi?id=nnnnn

====================

Note: patches 20208-20212 have been submitted by me.  They correct an
obvious build failure along the lines already applied to app/xedit, but
nevertheless they need independent review and approval.

Regards
Peter Breitenlohner <peb at mppmu.mpg.de>