Or'ing with a bit mask error?

Colin Harrison colin.harrison at virgin.net
Thu Nov 13 07:38:24 PST 2008


Hi,

In xserver/os/connection.c this or'ing with a bitmask should be an 'and', I
think?

--- save_connection.c   2008-11-13 15:33:52.000000000 +0000
+++ connection.c        2008-11-13 15:34:32.000000000 +0000
@@ -665,7 +665,7 @@

     /* Allow any client to connect without authorization on a launchd
socket,
        because it is securely created -- this prevents a race condition on
launch */
-    if(trans_conn->flags | TRANS_NOXAUTH) {
+    if(trans_conn->flags & TRANS_NOXAUTH) {
         auth_id = (XID) 0L;
     } else {
         auth_id = CheckAuthorization (proto_n, auth_proto, string_n,
auth_string, client, &reason);


Thanks,
Colin Harrison




More information about the xorg mailing list