Synaptics patch: orientation

[Éric Piel]

Mildred Ki'Lya schreef:
> Hi,
> 
> I just finished my orientation patch for synaptics. It's not heavily
> tested for the moment. If anyone could test ...
> 
> I added 4 options to the driver, quoting from the man page:
> 
>        Option "Orientation" "integer"
>               This option can be used to change the orientation of the  track‐
>               pad  and  can  takes  values  from  0  to 3. The default value 0
>               implies a normal orientation, other values can be used  to  have
>               respectively  an orientation set to the left, an inverted orien‐
>               tation, and an orientation set to the right.  This may be useful
>               in  combinaison with the orientation option of the XRandR exten‐
>               sion. You may notice that the values used are the  same  to  the
>               values  used  by  XRandR.   Along with this option, you might be
>               interested to enable the DontReportSize option. Read  its  docu‐
>               mentation to know why.
:
> 
>        Option "DontReportSize" "boolean"
:
>
Hi,
It's great, it's a feature I've been really looking for!
However, I have a couple of comments.

First, as this is clearly following the xrandr notions, I think it
should call the same things the same. So let's call it "rotation"
instead of "orientation" (unless in the inside of the Xrandr protocol
it's called orientation?).

Also, the idea of rotation has nothing specific to the synaptics
touchpad, it's just generic to any pointer device. For instance, I think
there was recently some patches to swap the axes in the evdev driver.
Shouldn't all this infrastructure be in a generic layer? At least, it
would be good if all the drivers conformed to the same features,
property names, and property behaviour :-)

Last but not least, as a user, only the rotation is useful. I don't care
about "DontReportSize", "VertSpeed" and "HorizSpeed", they are just
tricks that have to be done to get the touchpad correctly behaving after
a rotation is applied. They should be computed automatically.

> The next thing would be to automatically change the orientation of the
> trackpad when XRandR rotates the screen.
Certainly not at the X server level. I have two screens, which screen's
orientation are you going to use? However, at a higher level, like in
the gnome applet for screen resolution, that would be very useful.

See you,
Eric
-------------- next part --------------
A non-text attachment was scrubbed...
Name: E_A_B_Piel.vcf
Type: text/x-vcard
Size: 379 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20081111/10d27fdc/attachment.vcf>