how to set CFLAGS variable for compiling Xorg

Julien Cristau jcristau at debian.org
Wed Nov 5 09:59:08 PST 2008


On Wed, Nov  5, 2008 at 18:45:26 +0100, Peter Breitenlohner wrote:

> Indeed, for gcc I'd like to have those in, e.g., libX11:
> 	if test "x$GCC" = "xyes"; then
> 		GCC_WARNINGS="-Wall -Wpointer-arith -Wstrict-prototypes \
> 		-Wmissing-prototypes -Wmissing-declarations \
> 		-Wnested-externs -fno-strict-aliasing"
> 		X11_CFLAGS="$GCC_WARNINGS $X11_CFLAGS"
> 	fi
> plus the three suggested by Paulo
> 	-Wold-style-definition, -Wbad-function-cast, and
> 	-Wdeclaration-after-statement
> these either unconditional or conditional (e.g., via
>  --enable-extra-warnings); yet to be decided.
> 
-fno-strict-aliasing seems out of place here.

> I'm not so sure about -pedantic for gcc, that warns about 'long long', extra
> long strings, and others we can hardly avoid.
> 
agreed.

> From 597894712187f6c3941dcc656a0722cc3518b1f5 Mon Sep 17 00:00:00 2001
> From: Peter Breitenlohner <peb at mppmu.mpg.de>
> Date: Wed, 5 Nov 2008 18:20:40 +0100
> Subject: [PATCH] define the macro XORG_CHANGELOG_CMD
> 
> this is in a separate (new) file xorg-changelog-cmd.m4,
> such that we can use it before it is installed

meh. we can just depend on xorg-macros 1.2...

Cheers,
Julien



More information about the xorg mailing list