[PATCH] XRANDR: Make sure that hardware cursor is inside crtc all the time.

Maxim Levitsky maximlevitsky at gmail.com
Sat Mar 22 11:10:32 PDT 2008

On Saturday, 22 March 2008 19:16:16 Keith Packard wrote:
> On Sat, 2008-03-22 at 16:03 +0200, Maxim Levitsky wrote:
> > +	/* Adjust cursor position*/
> > +	xf86_reload_cursors (crtc->scrn->pScreen);
> I suspect a better plan would be to turn off the cursor before setting
> the mode, then reload it afterwards. Otherwise, you may ask the driver
> to position the cursors badly for the current mode.
> Splitting xf86_reload_cursors into two pieces, one which hides them and
> another which loads them should do the trick.
I was thinking about this, but why?
Increasing the resolution leaves the cursor where it is
and decreasing moves it toward upper left corner which is correct for both lower resolution
and higher too.

Besides there is a risk that even disabled cursor can make hardware mad if offscreen
I think it is better to move the cursor in current resolution, and then do the modesetting

Best regards,
	Maxim Levitsky

More information about the xorg mailing list