[PATCH] OpenBSD support for libpciaccess

Matthieu Herrb matthieu.herrb at laas.fr
Fri Mar 14 10:34:38 PDT 2008


Matthieu Herrb wrote:
> Mark Kettenis wrote:
>>> From: Eric Anholt <eric at anholt.net>
>>> Date: Wed, 12 Mar 2008 13:20:38 -0700
>>>
>>>> index 0dcff66..7e4a4d2 100644
>>>> --- a/hw/xfree86/os-support/bsd/i386_video.c
>>>> +++ b/hw/xfree86/os-support/bsd/i386_video.c
>>>> @@ -212,6 +212,9 @@ xf86OSInitVidMem(VidMemInfoPtr pVidMem)
>>>>  	pVidMem->mapMem =3D mapVidMem;
>>>>  	pVidMem->unmapMem =3D unmapVidMem;
>>>> =20
>>>> +	if (useDevMem)
>>>> +		pci_system_init_dev_mem(devMemFd);
>>>> +
>>> The changeset looks great, though I'd like to slip this hunk under
>>> #ifdef __OpenBSD__ or a version check so that non-OpenBSD doesn't have
>>> to catch up to libpciaccess from git to build.
>> Hmm, do people really want such clutter?
> 
> I understand Eric's concern. With the modular build, some care has to be
> taken not to break the compatibility too often.
> 
>> Anyway, the diff went in before I got this message.  Can you take this
>> up with Matthieu if you think something should be done about this?
> 
> I've been fighting with autoconf to find a proper way to do it (and got
> interrupted by other things). I'll commit something once I get it right.
> 
Here's the patch I propose.


-- 
Matthieu Herrb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pciaccess2.diff
Type: text/x-patch
Size: 1574 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20080314/36c985fc/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4033 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.x.org/archives/xorg/attachments/20080314/36c985fc/attachment-0001.bin>


More information about the xorg mailing list