[patch] fix driver hang when vt switch with rotation

Hong Liu hong.liu at intel.com
Tue Mar 11 18:18:20 PDT 2008


On Tue, 2008-03-11 at 11:34 -0700, Keith Packard wrote:
> On Tue, 2008-03-11 at 16:56 +0800, Hong Liu wrote:
> 
> > diff --git a/src/i830_driver.c b/src/i830_driver.c
> > index 854e377..5976ed8 100644
> > --- a/src/i830_driver.c
> > +++ b/src/i830_driver.c
> > @@ -3205,6 +3205,17 @@ I830EnterVT(int scrnIndex, int flags)
> >  	output->funcs->dpms(output, DPMSModeOff);
> >     }
> >  
> > +   for (o = 0; o < config->num_crtc; o++) {
> > +       xf86CrtcPtr crtc = config->crtc[o];
> > +
> > +       if (crtc->rotatedPixmap || crtc->rotatedData) {
> > +	   crtc->funcs->shadow_destroy(crtc, crtc->rotatedPixmap,
> > +		   			crtc->rotatedData);
> > +	   crtc->rotatedPixmap = NULL;
> > +	   crtc->rotatedData = NULL;
> > +       }
> > +   }
> > +
> 
> Would it be better to free this on LeaveVT instead?
> 

Thanks for the review, I will send the 2nd patch.

Thanks,
Hong




More information about the xorg mailing list