[PATCH] Require bash shell for symlink-mesa.sh

Dan Nicholson dbn.lists at gmail.com
Sat Mar 8 10:35:27 PST 2008


On Sat, Mar 8, 2008 at 10:32 AM, Joerg Sonnenberger
<joerg at britannica.bec.de> wrote:
> On Sat, Mar 08, 2008 at 04:20:02PM +0000, Igor Mozolevsky wrote:
>  > On 08/03/2008, Dan Nicholson <dbn.lists at gmail.com> wrote:
>  >
>  > >  - echo -n: Autoconf has feature tests to avoid this, but they're not used here.
>  > >  - Potentially empty variables not quoted
>  >
>  > echo -n is perfectly fine on sh (man sh on FreeBSD confirms that)
>
>  It is not. But it can be replaced portably by printf.
>  (For the archive: echo -n is a BSDism that is not part of POSIX)

Take a look at the second patch I sent. I just lifted the echo -n
feature test from autoconf and it works fine on all the shells I have.

--
Dan



More information about the xorg mailing list