Radeon MC setup cleanup

Alex Deucher alexdeucher at gmail.com
Sun Mar 2 13:08:19 PST 2008


On Sun, Mar 2, 2008 at 3:23 PM, Benjamin Herrenschmidt
<benh at kernel.crashing.org> wrote:
>
>  On Sun, 2008-03-02 at 14:12 -0500, Alex Deucher wrote:
>  >
>  > I committed a variation on this patch:
>  >
>  > - don't need to restore memmap on each mode set
>  > - don't need two copies of the mc regs stored in the driver
>
>  If you removed the setting of the memmap on non-DRI cases, you probably
>  just broke a whole bunch of machines who will blow up as soon as 2D is
>  used due to a crap memory map set by the firmware.

The memory map is still always init properly, I didn't remove that.
My commits only do the following:

- remove memmaprestore() on every mode set
- store mc info in once place in the driver instead of two

Alex



More information about the xorg mailing list