button->down used inconsistently

[Daniel Stone]

On Tue, Jun 17, 2008 at 09:44:55PM -0700, Keith Packard wrote:
> On Sun, 2008-06-15 at 03:18 +0200, Daniel Stone wrote:
> > I'd be happier with a usage count, e.g. as done with modifiers, since
> > they can trigger XKB actions, et al.
> 
> Buttons should act like keyboard keys. And, we shouldn't put user traps
> in where weird reconfiguration can result in stuck keys (as happened to
> me with the mix of broken X and DGA).

Check the XKB spec, buttons do a lot of adventurous things.

> I'm more interested in keeping things from breaking in the future than
> weird counting buttons.

It's hardly a lot of code.  It's easier to index something by byte than
bit, so it makes a lot of things vastly less error-prone.

The DGA case you cite had nothing to do with counting, and everything to
do with differing semantics.  I fixed them up for core delivery, but
forgot to do so for extended.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20080618/86518d93/attachment.pgp>