button->down used inconsistently

Peter Hutterer peter at cs.unisa.edu.au
Sun Jun 15 04:15:47 PDT 2008

On Sat, Jun 14, 2008 at 01:31:58PM -0700, Keith Packard wrote:
> Some parts of the server use button->down as a bitmask, other parts use
> it as a per-button down count. It seems like using it consistently as a
> bitmask would match the keyboard behaviour nicely. Also, lots of the
> server already uses this as a bitmask, so changing that would be a lot
> more invasive.

Please have a look at this patch. It's basically the inverse of your previous,
fixing up all other instances of button->down usage, assembling the bitmasks
as needed (through SetBitIf macro).
This allows us to keep the counter on the button->down, but also reply with
the correct state (as bitmask) in events.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-input-fix-up-usage-of-button-down-used-to-be-a-bi.patch
Type: text/x-diff
Size: 5614 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20080615/7cf66392/attachment.patch>

More information about the xorg mailing list