[New update] Patch to not fork/exec xkbcomp on X Server initialization

Paulo Cesar Pereira de Andrade pcpa at mandriva.com.br
Fri Jul 11 14:42:15 PDT 2008


Paulo Cesar Pereira de Andrade wrote:
>  Hi,
>
>  Daniel, can you give your opinion on these patches please?
>
>  They should be applied on server-1.4-branch. I am attaching
> a compressed version as it is over 7K lines of patches.
>
> (My interest on these patches is to reduce the X Server load
> time for like half the time in some custom projects, but with
> proper adjustments, the benefits could go upstream...)
>
>  It defaults to use /usr/share/X11/xkb/compiled to store
> compiled keymaps, and that directory probably should have mode
> 777 and stick bit set (or be owned by the only X user in the system).
>  If a compiled file exists, and is not a regular file, it causes
> an error, so it doesn't overwrite existing files, neither attempt
> to read non regular files.
  This patch is still for server-1.4-branch, but it reverts a lot
of "gratuitous" changes, and some things that did not really need
reverting, but this way it should be fully compatible with 1.4
servers without this patch.

  I will try to make an updated version for git-master if there
is interest (but the attached patch is the one should be used
for some Mandriva "mini pc" OEMs).
  Most of the geometry stuff must really be removed, as xkbcomp
already fails to compile it due to sections/doodads/etc with an
empty name. And it seems libxkbui is also broken for some time.
Example: changing keyboard models in xorgcfg doesn't update the
image anymore, but then, xorgcfg may even be last program that
uses that interface...

Paulo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0518-Don-t-fork-exec-xkbcomp-if-a-cache-file-exists.patch
Type: text/x-patch
Size: 81813 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20080711/e44136c3/attachment.bin>


More information about the xorg mailing list