[PATCH] Portability fixes

Joerg Sonnenberger joerg at britannica.bec.de
Fri Jan 25 05:52:03 PST 2008


On Fri, Jan 25, 2008 at 02:28:33PM +1100, Daniel Stone wrote:
> On Thu, Jan 24, 2008 at 09:21:59PM +0100, Joerg Sonnenberger wrote:
> > Hi all,
> > the attached patches deal with a number of issues:
> > - defining and undefining _POSIX_SOURCE is evil, it has side-effects
> > behond the just included header. pkgsrc hasn't hit issues with this and
> > is getting modular Xorg testing on a number of platforms.
> > - use real configure checks for a number of reentrant functions.
> > 
> > This patches has been tested at least on DragonFly, NetBSD, HP-UX and
> > AIX.
> 
> NAK.  Those complex paths are there for a reason, and removing them will
> break either or both of glibc and Solaris libc.

So make them conditional on Linux or Solaris. Breaking other systems is
a bad excuse for that practise.

Joerg



More information about the xorg mailing list