[PATCH] Disable visibility on Solaris

[pcpa at mandriva.com.br]

Quoting Alan Coopersmith <Alan.Coopersmith at Sun.COM>:

> Joerg Sonnenberger wrote:
>> Hi,
>> the attached patch is from Gilles Dauphin for Solaris with GCC 4.
>> Basically, enabling the symbol visibility on Solaris 10 breaks things
>> horribly.
>
> Really?   In what way?    I certainly haven't noticed any problems with it,
> though I usually build with the Sun compilers instead of gcc 4.

  I believe Joerg did not actually try to compile with something like
-fvisibility=hidden as that needs a lot of changes to current codebase
to actually work.

  But I have been wondering that this could cause problems when including
system or library headers that aren't actually compiled. I.e. maybe need
a ld[d]? that is aware about it, or use the appropriate #pragma's before
including those headers.

  The only other issue I noticed is when debugging. When printing the
name of a ".hidden" function in another module, like in in a structure
field, gdb will print something like <some_other_function+12345>.


> --
> 	-Alan Coopersmith-           alan.coopersmith at sun.com
> 	 Sun Microsystems, Inc. - X Window System Engineering

Paulo