Intel DRM: Is the x3500 closer to a 965G or a G33 or something else entirely.

Kevin DeKorte kdekorte at gmail.com
Wed Jan 23 12:53:23 PST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I was looking at the DRM code (from the parenthesis bug this morning)
and noticed that the drm kernel module thinks that my x3500 (G35) card
is a i965G. I know that the 965 and G35 are similar video chips, but I'm
wondering if the G35 is closer to the G33 than the 965. And if it is
would it be better to make this patch (I have not tested this, so I
don't even know if it works).

Info from Xorg.0.log
(II) PCI: 00:02:0: chip 8086,2982 card 1043,8276 rev 03 class 03,00,00
hdr 80



diff --git a/shared-core/i915_drv.h b/shared-core/i915_drv.h
index 7a0c0ea..ef38eee 100644
- --- a/shared-core/i915_drv.h
+++ b/shared-core/i915_drv.h
@@ -1201,7 +1201,6 @@ extern int i915_wait_ring(struct drm_device * dev,
int n,
 #define IS_I945GM(dev) ((dev)->pci_device == 0x27A2)

 #define IS_I965G(dev) ((dev)->pci_device == 0x2972 || \
- -                      (dev)->pci_device == 0x2982 || \
                       (dev)->pci_device == 0x2992 || \
                       (dev)->pci_device == 0x29A2 || \
                       (dev)->pci_device == 0x2A02 || \
@@ -1212,7 +1211,8 @@ extern int i915_wait_ring(struct drm_device * dev,
int n,

 #define IS_IGD_GM(dev) ((dev)->pci_device == 0x2A42)

- -#define IS_G33(dev)    ((dev)->pci_device == 0x29C2 || \
+#define IS_G33(dev)    ((dev)->pci_device == 0x2982 || \
+                       (dev)->pci_device == 0x29C2 || \
                        (dev)->pci_device == 0x29B2 ||  \
                        (dev)->pci_device == 0x29D2)



Thanks for the consideration..

Kevin

- --
Get my public GnuPG key from
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x7D0BD5D1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFHl6lD6w2kMH0L1dERAkS9AKCMoU6F5oTVufi6UQdfsnvpZJr8ewCfflsA
D6SrVPu5rQ6QgMC0BBbGV0g=
=klqi
-----END PGP SIGNATURE-----



More information about the xorg mailing list