Patch for bad border rendering on 965 w/ EXA+Compiz

[Eric Anholt]

On Mon, 2008-01-21 at 10:45 -0800, Bryce Harrington wrote:
> With -intel 2:2.2.0+git20080107-1ubuntu2 on 965GM, using EXA and Compiz,
> the borders of windows are drawn incorrectly:
> 
>  http://bryceharrington.org/files/borders-bad.png
> 
> Poking around a bit, I came up with the patch below which makes the
> issue go away.  Probably this is just covering up a real problem deeper
> down, so feedback would be appreciated.

Ugh.  The 965 code should really just be fixed to handle general
rotations rather than special cases.

> --- i965_render.c-orig	2008-01-08 02:18:58.000000000 +0000
> +++ i965_render.c	2008-01-21 18:11:16.000000000 +0000
> @@ -377,10 +377,12 @@ i965_check_rotation_transform(PictTransf
>      int a, b;
>      a = xFixedToInt(t->matrix[0][1]);
>      b = xFixedToInt(t->matrix[1][0]);
> -    if (a == -1 && b == 1)
> +    if (a == 0 && b == 1)
>  	return TRUE;
> -    else if (a == 1 && b == -1)
> +    else if (a == 1 && b == 0)
>  	return TRUE;
> +    else if (a != 0 && b != 0)
> +        return TRUE;
>      else
>  	return FALSE;
>  }
> _______________________________________________
> xorg mailing list
> xorg at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xorg
-- 
Eric Anholt                             anholt at FreeBSD.org
eric at anholt.net                         eric.anholt at intel.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20080121/a0d17f2c/attachment.pgp>