pciaccess clean up
Ian Romanick
idr at us.ibm.com
Mon Feb 25 10:23:43 PST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Tiago Vignatti wrote:
| Please review the attached. If no one objects I'll push this commits to
| the master branch in some days.
All of those changes look fine to me. There was a fair amount of dead
or semi-dead code that I left behind just to keep the patches smaller.
The PCI-rework patch was already several thousand lines, and I didn't
want any additional discouragement for people to review it. :)
| Also, ajax said that the only OS expected to work on ia64 is linux, so
| probably we can safely nuke 460gxPCI.[ch], altixPCI.[ch], e8870PCI.[ch],
| zx1PCI.[ch], which currently aren't ported to pciaccess. No problem here?
There was a reason I left those around when I did the original
PCI-rework, but I don't recall what it was. I believe there many have
been some other interactions with that code that, without access to IA64
hardware, I couldn't verify.
| I'm tracing why Xorg isn't posting correctly the secondary cards and for
| sure there's a lot of code (basically xf86pciBus.c) that will be also
| nuked after this be fixed (btw, is there anyone being able to start a
| secondary card under master branch today?).
I have had various reports of it not working correctly on systems with
two identical G450 PCI cards. I haven't had time to verify or debug yet.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
iD8DBQFHwwerX1gOwKyEAw8RAnyGAJ4r/QKMQNez4GD+WLUU//mvMmgafwCeIyO8
RLk2j/SRuJsmQBc1MO9IF8w=
=IbKx
-----END PGP SIGNATURE-----
More information about the xorg
mailing list