xorg/driver/xf86-input-fpit - [PATCH] Don't call xf86IsCorePointer.
Peter Hutterer
mailinglists at who-t.net
Mon Feb 4 18:44:58 PST 2008
pcpa at mandriva.com.br wrote:
> Quoting Peter Hutterer <mailinglists at who-t.net>:>
> Thanks for the review. When I made the patch I searched for other
> modules that had a similar problem, and used the same logic as in
> the acecad driver, that has an almost identical code, but that patch
> initializes to 1, and then checks the abi version before calling
> xf86IsCorePointer().
Yes, I know. I fixed this up a few days ago.
> In the case of the acecad driver, I also believe it could be
> changed to not call dlopen, and instead be linked agains't libsysfs.
>
> I don't know exactly the way the new input code works, so I
> don't think I deserve to get credit for this patch, but if you
> prefer I can write a new one initializing is_core_pointer to 0,
> before the #if :-)
yes please. I'm busy enough as it is.
On another note, do you actually have users that require these drivers?
Cheers,
Peter
More information about the xorg
mailing list