Patch for use of RT_NONE busted by an update to resource.c
jcristau at debian.org
Wed Dec 24 16:11:00 PST 2008
On Wed, Aug 6, 2008 at 15:30:09 -0700, Keith Packard wrote:
> On Wed, 2008-08-06 at 14:25 -0600, Pete Zaitcev wrote:
> > Hi All:
> > What would it take to include the attached patch for dixfonts.c?
> Uh, you've uncovered a serious bug in DIX. The XSELinux patches tried to
> automatically detect the difference between looking up a resource by
> class and looking up a resource by type. Turns out, it's hard to tell
> just by looking at the type/class parameter:
> RT_NONE has no bits set and is a Type lookup
> RT_WINDOW has lots of bits set, including some class bits and is a Type
> RC_ANY has all bits set and is a class lookup
> I suggest that the attempt to automatically separate these lookup types
> was misguided and that we should have dixLookupResourceByType and
> dixLookupResourceByClass as separate functions once again.
as far as I can tell your patch was never committed. Was this issue
fixed somehow, or is this still relevant?
More information about the xorg