Bad 2D performance with xf86-video-ati driver on RV350 AR [Radeon 9600]

Michel Dänzer michel at daenzer.net
Mon Dec 22 00:11:22 PST 2008


On Sun, 2008-12-21 at 22:41 +0100, Patrick Haller wrote:
> 
> From d5719514dd2eed4ecef9e4c8e8efe3724728cf65 Mon Sep 17 00:00:00 2001
> From: Patrick Haller <patrick.haller at haller-consult.com>
> Date: Sun, 21 Dec 2008 22:30:51 +0100
> Subject: [PATCH] Off-by-one when checking chipset limits caused exa
> migrations.
> 
> Off-by-one when checking chipset limits caused exa migrations.
> Changing the comparions
> improves the performance of x11perf -aa10text substantially if the
> chipset limits
> exactly match the virtual screen size.
> ---
>  src/radeon_exa_render.c |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
>  mode change 100644 => 100755 src/radeon_exa_render.c
> 
> diff --git a/src/radeon_exa_render.c b/src/radeon_exa_render.c
> index 55e55be..a922915
> --- a/src/radeon_exa_render.c
> +++ b/src/radeon_exa_render.c
> @@ -531,7 +531,7 @@ static Bool FUNC_NAME(R100PrepareComposite)(int
> op,
>  	return FALSE;
>  
>      if (pDstPicture->format == PICT_a8 &&
> RadeonBlendOp[op].dst_alpha)
> -        RADEON_FALLBACK("Can't dst alpha blend A8\n");
> +        RADEON_FALLBACK(("Can't dst alpha blend A8\n"));

Please don't mix in unrelated changes; if these RADEON_FALLBACKs need
fixing, make a separate change for that.

The limit fixes look good, thanks.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer



More information about the xorg mailing list