[PATCH] Don't release passive grabs unless all buttons are up

Thomas Jaeger thjaeger at gmail.com
Sun Dec 21 13:14:53 PST 2008

This turned out to be a little bit trickier than I initially thought,
since buttonsDown counts the number of physical buttons that are down,
before they are mapped to logical buttons.

The thing I'm unsure about (as should be evident from the patch), is
where to stick the declaration for the new function AllButtonsAreUp.


Thomas Jaeger wrote:
> I can't see any reason why we would treat buttons > 5 differently.  This
> patch simplifies client code by eliminating the need to call XGrabDevice
> after a button has been pressed and prevents race conditions that could
> result from that.
> Tom

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Don-t-release-grabs-unless-all-buttons-are-up.patch
Type: text/x-patch
Size: 2465 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20081221/2a4a22d1/attachment.bin>

More information about the xorg mailing list