Your recent changes to xorg-macros

Matthieu Herrb matthieu.herrb at
Tue Dec 9 23:15:13 PST 2008

Peter Breitenlohner wrote:
> Hi,
> in your recent commit 9ff834493ece0a0ea7d7f15c1706bab022362cc5 you have
> removed two warning flags for gcc < 4.
> Looking at older gcc versions I just saw that both flags were absent in
> gcc-3.3.x, but present in gcc-3.4.x.
> These flags are eminently useful to find places that need conversion to
> C.  Thus, please modify the test such that they are included for gcc >=
> 3.4.

The attached patch works for me on gcc 3.3 and 4.2. Can you confirm that
gcc 3.4 now uses the full flags again too, before I commit it?

Matthieu Herrb
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: xorg-macros.diff
URL: <>

More information about the xorg mailing list