xf86-input-evdev: Changes to 'master'

[Sascha Hlusiak]

Hi Daniel,

Am Tuesday 02 December 2008 10:13:50 schrieb Daniel Stone:
> On Tue, Dec 02, 2008 at 09:21:33AM +0100, Sascha Hlusiak wrote:
> > Please have a look at xkb/ddxCtrls.c @ XkbDDXUsesSoftRepeat. Software
> > autorepeat will exactly not happen in the server, if delay is set to 660
> > and rate is set to 25 (interval=40). This is the default setting when
> > starting up the server.
> >
> > Any comments on removing that complete chunk or on setting
> > XKB_ALWAYS_USES_SOFT_REPEAT?
>
> Hi,
> XkbDDXUsesSoftRepeat is pretty weird with checking for the AccessX
> flags, but based on a quick look at the XkbProcessKeyEvent flow, I think
> it's pretty safe to always just return 1 from XkbDDXUsesSoftRepeat.  We
> can gut the rest later on, as a continuation of xkb-atkins.  I don't
> have a clean tree around (am in the middle of a big rebase -i with large
> uncommitted changes), but if you or anyone else feels like committing
> that, and you've tested that it works:
> Signed-off-by: Daniel Stone <daniel at fooishbar.org>

I did some tests and it turned out that commit 
6867652c2c8ad563d5655302d94134592b10265b in xf86-input-evdev did not stop the 
event from sending repeated events at all. I replaced it with a patch that 
just ignores all autorepeated events in evdev. Has the same effect. 

And with kicking out the code of xserver, I get completely working and correct 
key autorepeat. Delay and rate is correct, default is working as well and 
modifiers don't repeat, as expected.


When applying the evdev patch but not the xserver patch, you get non-working 
autorepeat when it's set exactly to a delay of 660 and rate of 25 (interval 
40), which is the default. I'd rather send the patches to the list first, so 
you can decide which branches to commit them to.


Cheers,
Sascha
-------------- next part --------------
A non-text attachment was scrubbed...
Name: evdev-autorepeat.diff
Type: text/x-diff
Size: 953 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20081207/8a63c350/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xserver-autorepeat.diff
Type: text/x-diff
Size: 778 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20081207/8a63c350/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.x.org/archives/xorg/attachments/20081207/8a63c350/attachment.pgp>