[PATCH 2/2] xf86-video-geode: after reloading cursors, hide the cursor

Andres Salomon dilinger at queued.net
Thu Dec 4 19:41:59 PST 2008


On Thu, 4 Dec 2008 21:33:32 -0500
Andres Salomon <dilinger at queued.net> wrote:

> 
> Whenever we reload cursors, the LX driver needs to call hide_cursor()
> to ensure that the cursor is hidden until we finally unhide the
> cursor. Without this, we see ghost cursors during rotation or VT
> switches.
> 
> Signed-off-by: Andres Salomon <dilinger at debian.org>
> ---
>  src/lx_display.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 

Ugh, except that now when we use a 2bpp cursor, the cursor disappears
after rotating.  This patch fixes that, please use it instead.




Whenever we reload cursors, the geode driver needs to call hide_cursor()
to ensure that the cursor is hidden until we finally unhide the cursor.
Without this, we see ghost cursors during rotation or VT switches.

Signed-off-by: Andres Salomon <dilinger at debian.org>
---
 src/lx_display.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/src/lx_display.c b/src/lx_display.c
index 24e490f..b950203 100644
--- a/src/lx_display.c
+++ b/src/lx_display.c
@@ -315,8 +315,11 @@ lx_crtc_commit(xf86CrtcPtr crtc)
     }
 
     /* Load the cursor */
-    if (crtc->scrn->pScreen != NULL)
+    if (crtc->scrn->pScreen != NULL) {
 	xf86_reload_cursors(crtc->scrn->pScreen);
+	crtc->funcs->hide_cursor(crtc);
+	crtc->cursor_shown = FALSE;
+    }
 
     /* Renable the video */
 
-- 
1.5.6.5




More information about the xorg mailing list