[PATCH] dix: fix calculation of valuator events.

Keith Packard keithp at keithp.com
Thu Dec 4 16:56:09 PST 2008


On Fri, 2008-12-05 at 10:45 +1000, Peter Hutterer wrote:

>      if (num_valuators) {
> -        if ((num_valuators / 6) + 1 > MAX_VALUATOR_EVENTS)
> +        if (((num_valuators - 1) / 6) + 1 > MAX_VALUATOR_EVENTS)
>              num_valuators = MAX_VALUATOR_EVENTS;

This still looks wrong to me; why would you assign MAX_VALUATOR_EVENTS t
num_valuators? (no, I haven't looked at the surrounding code, just this
patch).

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20081204/1e792ee2/attachment.pgp>


More information about the xorg mailing list