Ansification of X.Org code: A question how to proceed

[Magnus Kessler]

On Tuesday 02 December 2008, Peter Breitenlohner wrote:
> On Mon, 20 Oct 2008, Alan Coopersmith wrote:
> > In general, I think everyone agrees conversion of the remaining bits
> > of code that use K&R/pre-ANSI-C89 style function prototypes &
> > declarations to C89 is a good thing (provided it's done correctly [1]),
> > ....
> >
> > [1] http://invisible-island.net/ansification/index.html
>
> Hi Alan, Adam, Julien, Paulo,
>
> now with xorg-macros-1.2 available, I have prepared patches to convert
> libICE and libSM to strict ANSI C as follows:
>
> (1)
> use xorg-macros-1.2
>
> Use XORG_CHANGELOG for rule to generate ChangeLog from git log
> Use XORG_CWARNFLAGS for compiler warning flags, leave CFLAGS to user
>
> (2)
> Activate CWARNFLAGS with lots of gcc warnings
>
> (3)
> towards ANSI C
>
> make default error handlers and some others static
>
> (4)
> ANSI C
>
> convert all old style function declarations

Hi Peter,

can you please check if there is some duplication of effort with the patch 
to ansify libICE I sent to the list some time ago?

http://lists.freedesktop.org/archives/xorg/2008-October/039799.html

Cheeers,

Magnus

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.x.org/archives/xorg/attachments/20081202/7f70bcb7/attachment.pgp>