[ANNOUNCE] xf86-video-intel 2.4.1

[Peter Clifton]

On Mon, 2008-08-18 at 09:39 +0800, Zhenyu Wang wrote:
> On 2008.08.15 12:56:53 +0100, Peter Clifton wrote:
> > On Fri, 2008-08-15 at 13:54 +0800, Zhenyu Wang wrote:
> > > Here is xf86-video-intel 2.4.1 release, mostly on bug and regression
> > > fixings for 2.4.0. Please try and give feedback. Thanks.
> > 
> > [snip]
> > 
> > > Jesse Barnes (4):
> > [...]
> > >       Reorganize VBIOS code
> > 
> > If I'm not mistaken, there is a field ordering bug in the above commit,
> > which I discovered broke dithering on my LCD panel. Jesse was checking
> > out my fix, but I've not seen anything pushed yet.
> > 
> 
> Could you try if this patch fixes the problem for you?

That is the patch I sent as a suggested fix when I reported the problem;
it did fix things for me.

Thanks for looking at this.

> diff --git a/src/i830_bios.h b/src/i830_bios.h
> index a8d9add..2b073f3 100644
> --- a/src/i830_bios.h
> +++ b/src/i830_bios.h
> @@ -152,13 +152,13 @@ struct bdb_lvds_options {
>      uint8_t panel_type;
>      uint8_t rsvd1;
>      /* LVDS capabilities, stored in a dword */
> -    uint8_t rsvd2:1;
> -    uint8_t lvds_edid:1;
> -    uint8_t pixel_dither:1;
> -    uint8_t pfit_ratio_auto:1;
> -    uint8_t pfit_gfx_mode_enhanced:1;
> -    uint8_t pfit_text_mode_enhanced:1;
>      uint8_t pfit_mode:2;
> +    uint8_t pfit_text_mode_enhanced:1;
> +    uint8_t pfit_gfx_mode_enhanced:1;
> +    uint8_t pfit_ratio_auto:1;
> +    uint8_t pixel_dither:1;
> +    uint8_t lvds_edid:1;
> +    uint8_t rsvd2:1;
>      uint8_t rsvd4;
>  } __attribute__((packed));
>  
> 
-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)