Patch for use of RT_NONE busted by an update to resource.c

Keith Packard keithp at keithp.com
Wed Aug 6 15:30:09 PDT 2008


On Wed, 2008-08-06 at 14:25 -0600, Pete Zaitcev wrote:
> Hi All:
> 
> What would it take to include the attached patch for dixfonts.c?

Uh, you've uncovered a serious bug in DIX. The XSELinux patches tried to
automatically detect the difference between looking up a resource by
class and looking up a resource by type. Turns out, it's hard to tell
just by looking at the type/class parameter:

 RT_NONE has no bits set and is a Type lookup
 RT_WINDOW has lots of bits set, including some class bits and is a Type
lookup
 RC_ANY has all bits set and is a class lookup

I suggest that the attempt to automatically separate these lookup types
was misguided and that we should have dixLookupResourceByType and
dixLookupResourceByClass as separate functions once again.

Please test and see if this patch doesn't solve your problem without
eliminating the (valid) use of RT_NONE.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Replace-dixLookupResource-by-dixLookupResourceBy-Typ.patch
Type: application/mbox
Size: 33506 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20080806/1c41f7d9/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20080806/1c41f7d9/attachment.pgp>


More information about the xorg mailing list