New handling of privates [was: Re: xf86-video-intel 2.5 release planning]

Lukas Hejtmanek xhejtman at ics.muni.cz
Fri Aug 1 04:46:04 PDT 2008


On Fri, Aug 01, 2008 at 01:40:51PM +0200, Tomas Carnecky wrote:
> The way I read your code, each DevPrivateKey is a unique index, no two 
> keys can can have the same index, is that correct? While I corrected the 
> DevPrivateKey usages throughout the code, I saw that many extensions 
> allocate one private key per object type (eg. one key for screens, one 
> key for windows, one key for pixmaps etc). There are more then 160 (just 
> a quick grep) private keys, so there is the possibility that each 
> PrivateRec array will be 160 pointers long and only sparsely occupated.
> 
> Compiz does the private handling nicely, it keeps a per-object-type list 
> of indices. But that approach would have to change large parts of the API.

I wondered why a hash structure cannot be used...

-- 
Lukáš Hejtmánek



More information about the xorg mailing list