xf86-video-savage: fix EXA UploadToScreen()

Alex Villacís Lasso a_villacis at palosanto.com
Sun Apr 6 17:26:22 PDT 2008

i r stupid

The sample replacement loop I sent before was incorrect after all. I was 
the pointer srcp (which is of type CARD32*) by an amount of src_pitch 
(which is
in bytes). Duh. No wonder pixmaps appeared squished.

Attached is a fixed patch which properly removes the EXA breakage. 
However, I am
still looking for a reference of commands available through BCI. Window 
is awfully slow, even with EXA fixed, and I wonder what EXA operations 
should be
accelerated in order to fix this. An interesting observation: under EXA, 
using xcompmgr
for simple composition actually makes window dragging *faster* than 
without it.

* EXA upload to screen must honor pitch of the source data

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-EXA-upload-to-screen-must-honor-pitch-of-the-source.patch
Type: text/x-patch
Size: 1490 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20080406/e5f23d94/attachment.bin>

More information about the xorg mailing list