[PATCH] xorg-server: pixan-include

[Dan Nicholson]

On 9/20/07, Arkadiusz Miskiewicz <arekm at maven.pl> wrote:
> On Friday 21 of September 2007, Dan Nicholson wrote:
> > On 9/20/07, Hanno Böck <ml at hboeck.de> wrote:
> > > miscstruct.h contains an include of pixman.h without a path.
> > >
> > > This will e.g. cause synaptics build to fail. Attached patch for
> > > xorg-xserver fixes it. Please apply.
> >
> > Not if they're using pkg-config:
> >
> > $ pkg-config --cflags pixman-1
> > -I/usr/include/pixman-1
>
> The problem is that now every external app that uses these headers needs to
> use pkgconfig to get pixman -I flags.

How is that different than any other application?

$ pkg-config --cflags cairo
-I/usr/include/cairo
$ pkg-config --cflags dbus-1
-I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include

> Why the include wasn't written as #include <pixman-1/whatever.h>?
>
> pixman-1 name was choosen afaik to be able to easily change api/abi in future
> and still have posibility go have both (old and new) pixman packages
> installed (without conflicts). Since now xserver uses pixman-1 API only and
> it simply could directly include <pixman-1/xyz> avoiding all the problems.

Well, that was a whole separate conversation about a month ago (it
looks like you even commented in the thread).

http://lists.freedesktop.org/archives/xorg/2007-August/026971.html

But I believe the main benefit is that moving from version -1 to -2
could be as simple as changing a pkg-config call.

--
Dan