[PATCH] xinput: Update for XInput in Xorg 1.4

Philip Langdale plangdale at vmware.com
Sun Oct 28 19:44:51 PDT 2007


So, I dug through the xinput code and found out why it wasn't
working properly with Xorg 1.4

We have two new extension types: XExtensionKeyboard and
XExtentionPointer while the utility assumes on XExtensionDevice.

Expanding that check solves the enumeration problem.

The second problem was that setting the mouse acceleration feedback
wasn't working - this was due to the utility assuming that the
PtrFeedbackClass was always the id=0 class - but now it's usually
the id=1 class. So I changed it to do an actual search. Another
possibility would be to demand the id as a parameter like
set-integer=feedback does.

xinput seems to be pretty much unmaintained right now, but the
canonical source is still hosted on x.org. I think we should
import it into git and maintain it there - it's still pretty much
the only way to tweak acceleration and button maps on a per device
basis.

I'd be willing to maintain it if necessary.

--phil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xinput.diff
Type: text/x-patch
Size: 2792 bytes
Desc: xinput.diff
URL: <http://lists.x.org/archives/xorg/attachments/20071028/7b7ec0d3/attachment.bin>


More information about the xorg mailing list