VNC patch for Xserver 1.3

[Daniel Stone]

On Tue, Oct 23, 2007 at 04:27:21PM +0200, Stefan Dirsch wrote:
> On Tue, Oct 23, 2007 at 01:42:08PM +0300, Daniel Stone wrote:
> > On Tue, Oct 23, 2007 at 12:34:34PM +0200, Stefan Dirsch wrote:
> > > On Mon, Oct 22, 2007 at 10:12:27PM +0200, Stefan Dirsch wrote:
> > > > AFAICS the pInfo structure is filled correctly in xf86rfbMouseInit(),
> > > > but the content gets lost again in InitInput() before calling
> > > > xf86ActivateDevice(). :-(
> > > 
> > > Obviously type_name/always_core_feedback, conf_idev/drv, and
> > > options/history_size are swapped on x86_64.
> > 
> > Sure it's being built with _XSERVER64?  All external modules require
> > xorg-server.h.
> 
> Meanwhile I figured out that it is *not* set. A patch, which fixes
> this issue for me, is attached. Some background:
> 
> * fixes segfault on 64bit during Xserver start; make sure to define
>   _XSERVER64 by having HAVE_DIX_CONFIG_H defined and therefore
>   including dix-config.h, so Atom is CARD32 instead of unsigned long
>   before and no longer messes up the pInfo structure in
>   xf86rfbMouseInit/xf86rfbKeybInit

If it's part of hw/xfree86, then it needs xorg-config.h, which includes
dix-config.h.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20071023/8740a668/attachment.pgp>