xserver: Branch 'master' - 2 commits

[Keith Packard]

On Wed, 2007-10-17 at 15:25 +0200, Luc Verhaegen wrote:

> Ah, so in effect, it is a further subspecification of M_T_PREFERRED.
> Understood.

Yeah, that's why it took me a while to fix this problem -- I had to
figure out that it mattered where the preference was stated, not only
where the mode was defined.

> Wouldn't it make more sense to define this as
> #define M_T_PREFERRED_USER 0x04
> to further distinguish the PREFERRED case in the lower nibble, and to 
> always set the PREFERRED bit next to this?

Or perhaps M_T_PREFERRED_DRIVER and M_T_PREFERRED_USER. Given that the
names are hidden entirely within the xf86/modes implementation, it
doesn't really make that much difference to me though. M_T_USERPREF is
probably not the best choice at any rate.

I didn't look at the values to try and detect a pattern; if 0x04 is
free, it would be fine to use that instead of the higher value.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20071017/a1f9a428/attachment.pgp>