PATCH: AOpen 965GM based mini pc does not have LVDS

[rglowery at exemail.com.au]

> On 2007.10.16 22:28:25 +0000, rglowery at exemail.com.au wrote:
>> I have confirmed the below patch works with my new AOpen MP965-DR mini
>> PC.
>>
>> Note, compared to the older 945GM based mini pc, this new one has an
>> Intel
>> 0x8086 SUBVENDOR_ID rather than AOpen 0xa0a0, which is why I made the
>> patch more targeted to the SUBSYS_ID rather than SUBSYS_ANY.
>
> yeah, I think it's ok.
>
>>
>> I'll leave it to the experts to decide if this is enough, or if the
>> quirks
>> code needs to be made smarter just in case other laptops that have an
>> LVDS
>> have all the same id's
>>
>
> Do you know any such laptops? That's bad.

I don't know of any such laptops, it was just a concern I had as I don't
have a full understanding of how these ID's are allocated.  Are
SUBSYS_ID's usually specific to a vendor or are they generic?

>
>>
>> --- xf86-video-intel.orig/src/i830_quirks.c     2007-10-14
>> 22:15:14.000000000 +1000
>> +++ xf86-video-intel/src/i830_quirks.c  2007-10-16 22:02:02.000000000
>> +1000
>> @@ -58,6 +58,7 @@
>>  static i830_quirk i830_quirk_list[] = {
>>      /* Aopen mini pc */
>>      { PCI_CHIP_I945_GM, 0xa0a0, SUBSYS_ANY, quirk_ignore_lvds },
>> +    { PCI_CHIP_I965_GM, 0x8086, 0x1999, quirk_ignore_lvds },
>>
>>      /* Apple Mac mini has no lvds, but macbook pro does */
>>      { PCI_CHIP_I945_GM, 0x8086, 0x7270, quirk_mac_mini },
>>
>
> I've pushed this one, thanks.
>

Thanks

-Rob