915gm/945gm/XAA lockup playing Xv video a second time (after mode-switch)

[Daniel Stone]

On Mon, Oct 15, 2007 at 09:04:30PM +0800, Keith Packard wrote:
> I think this is wrong -- it should cause the overlay to not get
> displayed on the CRTC when the crtc is re-enabled. Of course, you
> probably don't notice as the next frame will re-enable it. Testing with
> my 'xvtest' program will expose precisely what the original and new code
> does in this case.
> 
> 	git://people.freedesktop.org/~keithp/xvtest
> 
> hmm. The I830StopVideo call is about to free the video image, so there
> won't be any way we can redisplay it without getting it back from the
> client. I'm not sure we really care though; we lose the video data in
> lots of ways, and discarding the video buffer on mode switch eliminates
> a pinned buffer that will (eventually) cause us pains when we resize the
> frame buffer.

It's perfectly valid in this case to just fail the ReputImage hook,
which will cause the client to resubmit its frame.  This is one of the
things the Xv API _did_ actually get right here.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20071015/fcbbeaef/attachment.pgp>