915gm/945gm/XAA lockup playing Xv video a second time (after mode-switch)

Zhenyu Wang zhenyu.z.wang at intel.com
Sun Oct 14 19:11:37 PDT 2007


On 2007.10.12 15:23:23 +0000, Jesse Barnes wrote:
> On Friday, October 12, 2007 12:18 pm Peter Clifton wrote:
> > The following seems to fix it for me by forcing a reset of the Xv
> > regs after a mode-switch (Does the reset to VT1 clears them?),
> 
> Yeah, Enter/LeaveVT touch all sorts of regs.
> 
> > however I'm not sure whether it is a "fix" or a "workaround":
> >
> > --- xserver-xorg-video-intel-2.1.1.bwh.pcjc2.orig/src/i830_video.c   
> >   2007-10-11 17:31:01.000000000 +0100 +++
> > xserver-xorg-video-intel-2.1.1.bwh.pcjc2/src/i830_video.c  
> > 2007-10-11 17:31:01.000000000 +0100 @@ -2927,6 +2927,7 @@
> >          */
> >         I830StopVideo(pScrn, pPriv, TRUE);
> >         pPriv->overlayOK = FALSE;
> > +       pPriv->current_crtc = NULL;
> >         pPriv->oneLineMode = FALSE;
> >      }
> >  }
> 
> Patch looks reasonable to me, but Zhenyu should probably check just in 
> case he wants to do it another way.
> 

Looks correct to me, better to let Keith review this one and possible other
leak as he fixed overlay issues before.



More information about the xorg mailing list