Getting xserver patches reviewed

[Bernardo Innocenti]

Could someone please review the following patch and maybe
commit it in git if it looks good?

There are a bunch of older xserver and libX11 patches
that I submitted to the xorg@ list, which went mostly
ignored for a very long time.

I've been told there are no clear maintainers for the
xserver package.  This wouldn't be a problem if it
translate in difficulty getting patches from external
contributors being dropped.

I wonder if other developers have experienced the same
problem.


On 11/16/07 20:52, Bernardo Innocenti wrote:

> ---
>  hw/xfree86/dri/dri.c |   16 ++++++----------
>  1 files changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/hw/xfree86/dri/dri.c b/hw/xfree86/dri/dri.c
> index 2408357..b1d04e9 100644
> --- a/hw/xfree86/dri/dri.c
> +++ b/hw/xfree86/dri/dri.c
> @@ -73,7 +73,7 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
>  
>  #define PCI_BUS_NO_DOMAIN(bus) ((bus) & 0xffu)
>  
> -#if !defined(PANORAMIX)
> +#ifdef PANORAMIX
>  extern Bool noPanoramiXExtension;
>  #endif
>  
> @@ -307,7 +307,6 @@ DRIScreenInit(ScreenPtr pScreen, DRIInfoPtr pDRIInfo, int *pDRMFD)
>      drm_context_t *       reserved;
>      int                 reserved_count;
>      int                 i;
> -    Bool                xineramaInCore = FALSE;
>      DRIEntPrivPtr       pDRIEntPriv;
>      ScrnInfoPtr         pScrn = xf86Screens[pScreen->myNum];
>      DRIContextFlags	flags    = 0;
> @@ -320,20 +319,17 @@ DRIScreenInit(ScreenPtr pScreen, DRIInfoPtr pDRIInfo, int *pDRMFD)
>  	return FALSE;
>      }
>  
> +#ifdef PANORAMIX
>      /*
>       * If Xinerama is on, don't allow DRI to initialise.  It won't be usable
>       * anyway.
>       */
> -    if (xf86LoaderCheckSymbol("noPanoramiXExtension"))
> -	xineramaInCore = TRUE;
> -
> -    if (xineramaInCore) {
> -	if (!noPanoramiXExtension) {
> -	    DRIDrvMsg(pScreen->myNum, X_WARNING,
> +    if (!noPanoramiXExtension) {
> +	DRIDrvMsg(pScreen->myNum, X_WARNING,
>  		"Direct rendering is not supported when Xinerama is enabled\n");
> -	    return FALSE;
> -	}
> +	return FALSE;
>      }
> +#endif /* PANORAMIX */
>  
>      if (!DRIOpenDRMMaster(pScrn, pDRIInfo->SAREASize,
>  			  pDRIInfo->busIdString,


-- 
 \___/
 |___|   Bernardo Innocenti - http://www.codewiz.org/
  \___\  One Laptop Per Child - http://www.laptop.org/