[ANNOUNCE] xf86-video-intel-2.1.99

[Peter Clifton]

On Mon, 2007-11-12 at 12:03 +0000, Colin Guthrie wrote:
> 
> 
> In the first hunk it seems to be checking the wrong info. Should the
> following patch be applied:
> 
> --- src/i830_driver.c~  2007-11-09 12:12:39.000000000 +0000
> +++ src/i830_driver.c   2007-11-12 12:01:43.000000000 +0000
> @@ -2059,8 +2059,8 @@
>      * Make sure the DPLL is active and not in VGA mode or the
>      * write of PIPEnCONF may cause a crash
>      */
> -   if ((pI830->saveDPLL_B & DPLL_VCO_ENABLE) &&
> -       (pI830->saveDPLL_B & DPLL_VGA_MODE_DIS))
> +   if ((pI830->saveDPLL_A & DPLL_VCO_ENABLE) &&
> +       (pI830->saveDPLL_A & DPLL_VGA_MODE_DIS))
>            OUTREG(PIPEACONF, pI830->savePIPEACONF);
>     i830WaitForVblank(pScrn);
>     OUTREG(DSPACNTR, pI830->saveDSPACNTR);
> 

Looking at the patch attached to the bug report:
https://bugs.freedesktop.org/attachment.cgi?id=12305

(and from memory), I think you're right.. probably a copy/paste error
manually applying the patch with added comments.

Good catch!

(I'm CC'ing Jesse as I don't have commit access to fix this).

Best wishes,

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)