DDC overules xorg.conf displaysize

[Luc Verhaegen]

On Mon, May 07, 2007 at 12:22:34PM +0200, Remy Bosch wrote:
> Remy Bosch wrote:
> > Hi, all.
> >
> > I'm using xorg-server-1.3.0.0 and found that DDC overrules the
> > DisplaySize option in xorg.conf. Shouldn't variables be tested before
> > their value is overwritten?
> > If we look in hw/xfree86/ddc/ddcProperty.c from line 317:
> >     Monitor->widthmm = 10 * DDC->features.hsize;
> >     Monitor->heightmm = 10 * DDC->features.vsize;
> >
> > These lines bluntly overwrite the value written without testing.
> > By just checking for a value in Monitor->widthmm and Monitor->heightmm
> > you can prevent overwriting the size of the config.
> >
> > Like this:
> >     if (Monitor->widthmm <= 0)
> >         Monitor->widthmm = 10 * DDC->features.hsize;
> >     if (Monitor->heightmm <= 0)
> >         Monitor->heightmm = 10 * DDC->features.vsize;
> >   
> 
> I cound't find any other thing getting overwritten, though I'm not too
> familiar with the code. The function where this bug was found is
> xf86DDCMonitorSet.
> 
> I have to set questionmarks at the following line in the same function
> right after the displaysizes are set:
> [code]
>     /* If this is a digital display, then we can use reduced blanking */
>     if (DDC->features.input_type)
>         Monitor->reducedblanking = TRUE;
>     /* Allow the user to also enable this through config */
> 
> [/code]
> 
> I see no indication that a value from config is used to enable reduced
> blanking.
> 
> 
> Regards,
> 
> Remy Bosch
> Should
> 

http://gitweb.freedesktop.org/?p=xorg/xserver.git;a=blobdiff;h=aded9132d83f80533de942cccdfd5ed85e0087b5;hp=f4b44e67d9e9c3e1a566c2ea80bd7d77a7bd1336;hb=3664c3ebf348d07ae3fe301fb8720adf32cf6d64;f=hw/xfree86/common/xf86Config.c

Luc Verhaegen.
http://unichrome.sf.net/