[PATCH 1/6] xserver: Option memory leak fixes

Magnus Vigerlöf Magnus.Vigerlof at home.se
Thu Mar 29 16:58:58 PDT 2007

On Thursday 29 March 2007 01:52, Jesse Barnes wrote:
> On Wednesday, March 28, 2007 3:03 pm Magnus Vigerlöf wrote:
> > Option memory leak fixes
> >
> > Correction of a few small memory leaks in the option handling
> > functions and the places where these are called in a faulty way.
> Looks good to me.  Too bad the functions don't have better names that
> indicate whether they're doing the allocation or whether they expect
> the caller to do it (as in the case of xf86addNewOption), or at the
> very least some documentation...

Too bad they don't have proper error handling in the case of low memory... I 
can't say I'm proud of these corrections, but at least it should not leak 
during normal usage when there's memory available...

  Magnus V

More information about the xorg mailing list