[pixman] Bug in fbStore_b2g3r3 ?

Dan Amelang daniel.amelang at gmail.com
Mon Jun 18 23:10:44 PDT 2007


(Pixman doesn't have its own mailing list (yet?), so apologies for the
widespread distribution)

It appears that fbStore_b2g3r3 in pixman-compose.c is incorrect. I
think it's actually implementing something more like an
fbStore_b3g3r2. Behold (the relevant lines:

WRITE(pixel++, ((b     ) & 0xe0) |
	                 ((g >> 3) & 0x1c) |
	                 ((r >> 6)       ));

Cue Keith's defence that the whole of pixman was written in a day, etc. :)

Dan Amelang



More information about the xorg mailing list