[PATCH 2/3] dix: more lookup function consolidation, macro removal

Keith Packard keithp at keithp.com
Mon Jan 29 22:40:39 PST 2007

On Mon, 2007-01-29 at 20:04 -0500, Eamon Walsh wrote:

> +_X_EXPORT int
> +dixLookupResource(pointer *result, XID id, RESTYPE rtype,
> +		  ClientPtr client, Mask mode)

I'm not entirely comfortable with this change; it doesn't make the old
distinction between looking up by type and by class very clear, instead
hiding it in the magic of the resource type bits:

> +    int istype = rtype & (RC_LASTPREDEF - 1);

I'm not sure how to improve this without also leaving the duplication of
code that the old class/type looking mechanism entailed.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20070129/d9b8d9da/attachment.pgp>

More information about the xorg mailing list