[PATCH] i810: Add workaround for bad BIOS mode on Fujitsu laptops

Keith Packard keithp at keithp.com
Mon Jan 29 10:15:23 PST 2007

On Sun, 2007-01-28 at 23:32 -0800, Tony Lindgren wrote:
> * Keith Packard <keithp at keithp.com> [070128 23:22]:
> > On Sun, 2007-01-28 at 22:48 -0800, Tony Lindgren wrote:
> > > Hi all,
> > > 
> > > Just hacking a bit to get the i810 modesetting driver to work on my
> > > laptop :) Here are few patches.
> > 
> > We've started adding a list of 'quirks' to the EDID parsing stuff;
> > perhaps we need a similar list of quirks for the BIOS data.
> OK. Originally when trying to fix this I was thinking that the BIOS
> mode should be verified against all the probed modes, and if the BIOS
> mode does not match any VESA modes, then ignore the BIOS mode. But
> then I noticed that the probed modes use BIOS mode for some
> checks..

BIOS modes are often not standard VESA modes, and often use non-standard
timing as well. I'm surprised that your BIOS mode is so broken; we've
never seen that before...

> Maybe there should be some option to ignore BIOS mode? And then have
> some quirks for known bad BIOS modes.

We need a mode to use in place of the broken BIOS mode; perhaps the
quirk should just be that we take the panel size from the BIOS and
generate a mode using the GTF.

> Yeah, the LVDS is streched out estimated 2x horizontally, vertical is
> OK without the patch. Are you suggesting that the bug would be in the
> BIOS mode parsing?

I don't know where the bug lies. It's possible we're mis-interpreting
the BIOS data, it's also possible we should ignore the timing data and
use GTF if it looks screwy
> > Can the BIOS set the mode correctly?
> I don't think so unless there's a bug in parsing the BIOS mode.
> I guess I could try to dump the BIOS, or let me know what data
> you need.

The question is whether the BIOS can set the native panel mode
correctly. You can test this by using the master branch; if that works,
then the BIOS is doing the right thing and we're doing the wrong thing
somehow. If the BIOS can get it right, then we should be able to get the
modesetting code working.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20070129/0bc3f03d/attachment.pgp>

More information about the xorg mailing list