[PATCH]: Fix GLX crashes on RISC cpus.

Xavier Bestel xavier.bestel at free.fr
Fri Dec 28 02:47:33 PST 2007


On jeu, 2007-12-27 at 16:36 -0800, David Miller wrote:
> From: Jaymz Julian <jaymz at artificial-stupidity.net>
> Date: Thu, 27 Dec 2007 22:35:34 +1100
> 
> > It's not random (it rotates the result in a specific way), but
> that's not the
> > point - you can easily check for this bevaviour by doing something
> like:
> > 
> > (warning: written into email client :-p.  Bonus points if you modify
> > it to check endian at the same time)
> 
> Actually we can't implement this as a run-time check, I just tried.
> 
> The problem is that we can't handle cross-compilation cases properly.

Hi again,

(uninformed opinion ahead)
I didn't look at where it's used, but if as I think it is, it's for
aligning 64bits data, and if it doesn't cause ABI trouble it's perhaps
even better to always define it. Processors that allow unaligned
accesses do so at a cost, even when they don't trap.

	Xav





More information about the xorg mailing list