[PATCH]: Fix GLX crashes on RISC cpus.

[pcpa at mandriva.com.br]

Quoting David Miller <davem at davemloft.net>:

> From: Daniel Stone <daniel at fooishbar.org>
> Date: Thu, 27 Dec 2007 09:56:43 +0000
>
>> On Thu, Dec 27, 2007 at 12:34:16AM -0800, David Miller wrote:
>> > As another example, half the input drivers in the tree don't even
>> > build, and it's been like this for over two years.  There has been
>> > some level of forward progress, but the regression is still mostly
>> > there.
>>
>> http://bugs.freedesktop.org/show_bug.cgi?id=10262 which has been
>> RESOLVED/FIXED since August?
>
> Look at how it's like pulling teeth to get someone to fix build
> regressions they added, even downloading the drivers to do a test
> build seems to be considered a chore.
>
> Also note how many times that bug had to get closed and reopenned
> before it really was fixed.  Finally, some of the input drivers
> currently don't build:
>
> xf86-input-elographics:
>
> gcc -DHAVE_CONFIG_H -I. -I. -I.. -g -O2 -I/opt/XORG/include/xorg 
> -I/opt/XORG/include/pixman-1 -I/opt/XORG/include -I../src -MT 
> xf86Elo.lo -MD -MP -MF .deps/xf86Elo.Tpo -c xf86Elo.c  -fPIC -DPIC -o 
> .libs/xf86Elo.o
> xf86Elo.c:68:24: error: xf86_ansic.h: No such file or directory
> make[2]: *** [xf86Elo.lo] Error 1
>
> xf86-input-magictouch:
>
> clude/pixman-1 -I/opt/XORG/include -I../src -MT xf86MagicTouch.lo -MD 
> -MP -MF .deps/xf86MagicTouch.Tpo -c xf86MagicTouch.c  -fPIC -DPIC -o 
> .libs/xf86MagicTouch.o
> xf86MagicTouch.c:25:24: error: xf86_ansic.h: No such file or directory
> xf86MagicTouch.c: In function 'xf86MagicAllocate':
> xf86MagicTouch.c:1019: warning: assignment makes pointer from integer 
> without a cast
> make[2]: *** [xf86MagicTouch.lo] Error 1
>
>>      I'm not holding this up as an example of brilliant development,
>>      but it's not a two-year regression, however you paint it.
>
> Sure, it was a one-year regression.
>
> But a known build regression that lasts for a year, sucks.

  The xf86 libcwrapper support was removed around one month ago. Almost
funny it was when I posted about it, talking that it should be fixed, as
it was broken for quite some time, anyway, the only real use of the
libcwrapper was for binary only drivers, where problems should be solved
in the server, but binary only distributors usually use other methods to
try to resolve incompatibilites betwen Linux distros. And binary only
drivers that work on different operating systems, on the same arch and
using GNU tools, is more of a dream...

  You can get the input modules to build if you checkout server-1.4-branch
or tag xorg-server-1.4, and probably others. But you will get runtime
crashes on like half them, due to unresolved symbols, and I believe those
that don't have unresolved symbols aren't working properly, due to the
X Input Hotplug rework.

  I have been away from Linux for quite some time, but I am working on
trying to get a stable set of packages for Mandriva. Other problems that
exist are things like the vga driver not working, this is something that
should not have been broken literally for years. If you check the
existing video modules, there are other problems, mainly due to not
compiling with more verbose gcc warnings neither using any tools to check
for things like unresolved symbols (I am using a perl script that parses
the output of "objdmup -t -T -w --demangle" and cross references symbols
and "simulates" loading of shared libraries), i.e. things like modules with
missing symbols (function calls) that are actually macros, but the proper
headers were not included, C files declaring "extern" functions that don't
exist, etc.

  More than half of the git modules don't have a tag also, so it is
impossible to checkout a specific "official" release. Currently I am
tagging my own mirror of freedesktop, but I need to review these tags,
as several of them probably don't match the released tarballs, and this
isn't really an easy job (and I am doing it kind of like in a rush...),
but I hope to post the proper git commits and suggested tag names soon or
later (most have the format <name>-<version>).

  Enough ranting :-)

Paulo