[PATCH]: Fix GLX crashes on RISC cpus.

[Daniel Stone]

On Wed, Dec 26, 2007 at 11:56:44PM -0800, David Miller wrote:
> From: Daniel Stone <daniel at fooishbar.org>
> Date: Thu, 27 Dec 2007 07:43:52 +0000
> 
> > On Wed, Dec 26, 2007 at 10:44:21PM -0800, David Miller wrote:
> > > RISC chips that trap on unaligned loads and stores need to
> > > define __GLX_ALIGN64.  This used to get added to the cflags
> > > in the old *.cf files but it no longer does in the modular
> > > X server.
> > 
> > This is the wrong approach for modular; instead of hardcoding a list of
> > CPUs that throw errors on unaligned accesses, you could just check
> > whether or not unaligned accesses work.
> 
> I wish someone had said this over a year ago to Jurij instead of
> letting the patch and the issue rot all this time.

Oddly enough, I don't read every single bug report that comes through,
so attributing this one to ignorance rather than deliberate malice might
be acceptably charitable here.

> > > Also, Alpha needs to pass -mieee to the compiler as well.
> > 
> > How portable is this?
> 
> I think it's widely usable on Alpha compilers.
> 
> But that's not important because I think the way to fix this is to not
> continue deferring the bug fix until it's perfect, but rather to put
> something that fixes the crashes and misbehaviors into the tree now
> and refine it over time as needed.

I don't disagree with you, but surely there's nothing wrong with trying
to find things out in advance either.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20071227/d172540e/attachment.pgp>