[PATCH] dix: Always add valuator information if present
Magnus Vigerlöf
Magnus.Vigerlof at home.se
Mon Dec 17 10:24:57 PST 2007
On söndag 16 december 2007, Daniel Stone wrote:
[...]
> > As long as the net result will be that the coordinates in the InputDevice
> > coordinate space will be included in the event that reaches the XClient
> > (for example Gimp that doesn't look at the screen-scaled x&y, but will
> > use the high-resolution axis that a Wacom tablet will provide).
>
> Ah! Good point. Yes, we always want to send valuators if they're at all
> scaled. But given that we need to send all valuators on motion events
> anyway, it doesn't make sense overoptimising the button case.
My thought went along some of those lines since it was only relative
button-events that didn't get the valuators included. Currently the core and
extended x&y are required to be same so they are not scaled at the moment,
but I hope the other patch I sent (only sent as an [RFC]) could be used in
some way until you will have time to do the real work for 1.6.
Btw, the patch removes a possible false unknown event if an absolute
Button-event is generated without any valuators. I that case we got the core
event and the extended event with the MORE_EVENTS bit set, but the valuator
event was never populated so that would be sent with whatever data was in
there at the time of event generation.
Cheers
Magnus
More information about the xorg
mailing list