[PATCH] dix: Always add valuator information if present

Daniel Stone daniel at fooishbar.org
Sun Dec 16 07:51:42 PST 2007


On Sun, Dec 16, 2007 at 02:25:10PM +0100, Magnus Vigerlöf wrote:
> Send valuator information with all event types, not only for
> MotionEvents and absolute button events. Relative button events
> will have the coordinate set to 0,0 for the extended event
> unless this information is included.

Er, except they won't, because DeviceKeyButtonPointer includes both
event_{x,y} and root_{x,y}, so you always have the first two axes (as I
just verified with people.fd.o/~daniels/xiread.c and my trackpoint).  If
you want to get extended axes, hmm.  Okay, turns out I misread the spec,
and it said that relative devices _may_ report all zeros in the valuator
fields, not must, as I thought.  I'll merge a slightly modified version;
only send separate valuators if there are more than two, or it's a
motion notify.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20071216/ca7ca7bd/attachment.pgp>


More information about the xorg mailing list